Skip to content

feat(ci): promote ci junit-process from shim to native Rust#1467

Draft
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716from
devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4
Draft

feat(ci): promote ci junit-process from shim to native Rust#1467
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716from
devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 27, 2026

Third and final layer of the port: the orchestration that wires
the JUnit parser, OTLP encoder, uploader, and a new quarantine
API client together, plus the native clap dispatch that retires
the Python shim for this subcommand.

Two new modules under junit_process:

  • quarantine POSTs failing test names to
    /v1/ci/<owner>/repositories/<repo>/quarantines/check and
    splits the response into quarantined / non-quarantined buckets.
    The categorize step counts unknown names as non-quarantined to
    match Python (an API that silently drops a name still blocks
    the corresponding failure).

  • command::run orchestrates the per-invocation flow: resolve
    the token / repo / target branch (falling back to the CI-env
    detector for the latter two), expand **/*/? patterns into
    paths, parse every file, hit the quarantine endpoint, feed the
    quarantined set into the OTLP builder so each case span gets
    the right cicd.test.quarantined value at build time, upload
    the gzipped protobuf, and render the report. Network failures
    on quarantine or upload are non-fatal — the report calls them
    out and the verdict still fires based on
    failing_tests_not_quarantined_count.

The dispatch layer in main.rs promotes
Subcommands::Ci(CiSubcommand::JunitProcess) from
ShimmedArgs to a full clap variant, adds the
("ci", "junit-process") entry to NATIVE_COMMANDS, and routes
through mergify_ci::junit_process::run. ci junit-upload
(deprecated) keeps its shim.

The detector gains get_tests_target_branch (base ref OR head
ref) so the orchestrator can derive the branch the quarantine API
should look up tests on without round-tripping through Python.

Output is byte-for-byte the same as the Python implementation's
process_junit_files — same separators, same emoji, same
Run ID/Exit code lines, same ┌ … │ … └─ box-drawn failure
blocks. End-to-end smoke against the live junit_fail.xml
fixture exits 1 on a non-quarantined failure and 0 on an
all-pass run, matching Python's contract.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

Depends-On: #1466

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 07:53 Failure
@jd jd mentioned this pull request May 27, 2026
Draft
@jd jd temporarily deployed to func-tests-live May 27, 2026 07:53 — with GitHub Actions Inactive
This was referenced May 27, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
Open
@jd
Copy link
Copy Markdown
Member Author

jd commented May 27, 2026 •
edited
Loading

This pull request is part of a Mergify stack:

# Pull Request Link
1 refactor(queue): drop indexmap, group_by_scope returns a Vec<(K, V)> #1445
2 refactor(ci): swap uuid for getrandom in the GHA heredoc delimiter #1446
3 refactor(config): standardize the workspace on serde_yaml_ng for YAML parsing #1447
4 test(ci): add live smoke test for ci scopes select-all path #1460
5 feat(rust): port ci scopes to native Rust #1461
6 feat(ci): swap Python's JUnit XML parser for the native Rust parser #1465
7 feat(ci): encode JUnit cases as OTLP and upload to Mergify CI Insights #1466
8 feat(ci): promote ci junit-process from shim to native Rust #1467 👈
9 feat(ci): promote ci junit-upload from shim to native as a deprecated alias #1468

This was referenced May 27, 2026
Open
Open
Open
Open
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 27, 2026 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of Depends-On in the body of the pull request

🔴 🤖 Continuous Integration

Waiting for

  • check-success=ci-gate
This rule is failing.
  • all of:
    • check-success=ci-gate

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by>=2
This rule is failing.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from 8078737 to ed7a74d Compare May 27, 2026 08:27
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from 3a3d6cc to ee06c7a Compare May 27, 2026 08:27
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:27 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:27 — with GitHub Actions Inactive
@jd
Copy link
Copy Markdown
Member Author

jd commented May 27, 2026 •
edited
Loading

Revision history

# Type Changes Reason Date
1 initial 8078737 2026-05-27 08:27 UTC
2 content 8078737 → ed7a74d 2026-05-27 08:27 UTC
3 content ed7a74d → 6eeb3d9 2026-05-27 08:46 UTC
4 content 6eeb3d9 → 6317d48 (raw) 2026-05-27 09:00 UTC
5 rebase 6317d48 → a353a93 (rebase only) 2026-05-27 09:18 UTC
6 rebase a353a93 → cc3c840 (rebase only) 2026-05-27 10:04 UTC
7 rebase cc3c840 → e5b9480 (rebase only) 2026-05-27 10:15 UTC
8 rebase 5474036 → 70d22a9 (rebase only) 2026-05-28 08:20 UTC
9 content 70d22a9 → ee35991 (raw) Update parse_all in command.rs to build ParseResult with the new suite_names field, introduced in the Phase A swap. 2026-05-28 09:45 UTC
10 content ee35991 → 951ac81 (raw) Update parse_all / UploadMetadata construction in command.rs for the new spans.rs API (build_traces returns Result; UploadMetadata gains run_id field). Both came in via the Phase B Python bridge work. 2026-05-28 10:21 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 08:28 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from ed7a74d to 6eeb3d9 Compare May 27, 2026 08:46
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from ee06c7a to 0c646f7 Compare May 27, 2026 08:46
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:46 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:46 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:46 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 10:06 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from cc3c840 to e5b9480 Compare May 27, 2026 10:15
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from dd1bfdf to 2ecb8c2 Compare May 27, 2026 10:15
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:15 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:15 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:15 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 10:15 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from e5b9480 to 5474036 Compare May 28, 2026 07:44
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from 2ecb8c2 to 138ac43 Compare May 28, 2026 07:44
@jd jd temporarily deployed to func-tests-live May 28, 2026 07:44 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 28, 2026 07:44 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 28, 2026 07:45 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from 5474036 to 70d22a9 Compare May 28, 2026 08:20
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from 138ac43 to e901cae Compare May 28, 2026 08:20
@jd jd temporarily deployed to func-tests-live May 28, 2026 08:20 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 28, 2026 08:20 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 28, 2026 08:20 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 28, 2026 08:21 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from 70d22a9 to ee35991 Compare May 28, 2026 09:45
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from e901cae to 0e3e818 Compare May 28, 2026 09:45
@jd jd temporarily deployed to func-tests-live May 28, 2026 09:45 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 28, 2026 09:45 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 28, 2026 09:45 Failure
@jd @claude
feat(ci): promote ci junit-process from shim to native Rust
951ac81 
Third and final layer of the port: the orchestration that wires
the JUnit parser, OTLP encoder, uploader, and a new quarantine
API client together, plus the native clap dispatch that retires
the Python shim for this subcommand.

Two new modules under `junit_process`:

- `quarantine` POSTs failing test names to
  `/v1/ci/<owner>/repositories/<repo>/quarantines/check` and
  splits the response into quarantined / non-quarantined buckets.
  The categorize step counts unknown names as non-quarantined to
  match Python (an API that silently drops a name still blocks
  the corresponding failure).

- `command::run` orchestrates the per-invocation flow: resolve
  the token / repo / target branch (falling back to the CI-env
  detector for the latter two), expand `**`/`*`/`?` patterns into
  paths, parse every file, hit the quarantine endpoint, feed the
  quarantined set into the OTLP builder so each case span gets
  the right `cicd.test.quarantined` value at build time, upload
  the gzipped protobuf, and render the report. Network failures
  on quarantine or upload are non-fatal — the report calls them
  out and the verdict still fires based on
  `failing_tests_not_quarantined_count`.

The dispatch layer in `main.rs` promotes
`Subcommands::Ci(CiSubcommand::JunitProcess)` from
`ShimmedArgs` to a full clap variant, adds the
`("ci", "junit-process")` entry to `NATIVE_COMMANDS`, and routes
through `mergify_ci::junit_process::run`. `ci junit-upload`
(deprecated) keeps its shim.

The detector gains `get_tests_target_branch` (base ref OR head
ref) so the orchestrator can derive the branch the quarantine API
should look up tests on without round-tripping through Python.

Output is byte-for-byte the same as the Python implementation's
`process_junit_files` — same separators, same emoji, same
`Run ID`/`Exit code` lines, same `┌ … │ … └─` box-drawn failure
blocks. End-to-end smoke against the live `junit_fail.xml`
fixture exits 1 on a non-quarantined failure and 0 on an
all-pass run, matching Python's contract.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change-Id: I6bd59de407ddcd4196bdd7e7b8ddb4a88885af7a
@jd jd force-pushed the devs/jd/worktree-rust-port/encode-junit-cases-otlp-upload-mergify-ci-insights--cbc72716 branch from 0e3e818 to 19c0db2 Compare May 28, 2026 10:21
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from ee35991 to 951ac81 Compare May 28, 2026 10:21
@jd jd temporarily deployed to func-tests-live May 28, 2026 10:21 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 28, 2026 10:21 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 28, 2026 10:21 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 28, 2026 10:21 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jd